From 09f73f3464ad78d9847c36bc108f5cfdecf86870 Mon Sep 17 00:00:00 2001 From: James Rosewell Date: Sun, 25 Oct 2026 12:31:50 +0000 Subject: [PATCH 1/2] Pass the TAC data file to the performance example Given no data file, the example searches the folders for 51Degrees-LiteV4.1.hash. In the nightly build that search currently finds the CI's link to the TAC file under tests/ before the Lite file, which depends on the folder order. Pass the TAC file explicitly, and fall back to the example's default when there is no TAC file because no licence key was given. --- ci/run-performance-tests.ps1 | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/ci/run-performance-tests.ps1 b/ci/run-performance-tests.ps1 index 53e82b402..5b2608f3b 100644 --- a/ci/run-performance-tests.ps1 +++ b/ci/run-performance-tests.ps1 @@ -14,7 +14,20 @@ try $perfSummary = New-Item -ItemType directory -Path test-results/performance-summary -Force $perfJSONOutputName = "results_$Name.json"; - node fiftyone.devicedetection.onpremise/examples/onpremise/performance-console/performance.js --jsonoutput $perfJSONOutputName || $($testsFailed = $true) + # Pass the TAC data file explicitly, so the graph is measured with the full + # data file rather than whichever file the example's folder search finds + # first. Without a licence key the TAC file isn't downloaded, and the + # example falls back to its default Lite data file. + $dataFile = 'fiftyone.devicedetection.onpremise/device-detection-cxx/device-detection-data/Enterprise-HashV41.hash' + $dataFileArgs = @() + if (Test-Path $dataFile) { + $dataFileArgs = '--datafile', $dataFile + } + else { + Write-Warning "No TAC data file at '$dataFile', so the example uses its default data file" + } + + node fiftyone.devicedetection.onpremise/examples/onpremise/performance-console/performance.js @dataFileArgs --jsonoutput $perfJSONOutputName || $($testsFailed = $true) Write-Output "Path to performance results - /" From 1031399b4cdf5568721eb66f394b0d8fbc523e21 Mon Sep 17 00:00:00 2001 From: James Rosewell Date: Sun, 25 Oct 2026 12:32:43 +0000 Subject: [PATCH 2/2] Use US spelling of license in the data file comment --- ci/run-performance-tests.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/run-performance-tests.ps1 b/ci/run-performance-tests.ps1 index 5b2608f3b..af0f5d9cb 100644 --- a/ci/run-performance-tests.ps1 +++ b/ci/run-performance-tests.ps1 @@ -16,7 +16,7 @@ try # Pass the TAC data file explicitly, so the graph is measured with the full # data file rather than whichever file the example's folder search finds - # first. Without a licence key the TAC file isn't downloaded, and the + # first. Without a license key the TAC file isn't downloaded, and the # example falls back to its default Lite data file. $dataFile = 'fiftyone.devicedetection.onpremise/device-detection-cxx/device-detection-data/Enterprise-HashV41.hash' $dataFileArgs = @()